Created a tutorial, made some changes to the home page #13
Conversation
There was a problem hiding this comment.
Lovely @evildmp. Thank you! I'm travelling, but will review, merge and deploy this as soon as I'm home.
🥰
|
On 2 Jun 2023, at 15:40, Carlton Gibson ***@***.***> wrote:
Lovely @evildmp. Thank you! I'm travelling, but will review, merge and deploy this as soon as I'm home.
More coming soon too.
Daniele
|
docs/source/tutorial.rst
Outdated
|
|
||
| You notice that the page is now rendered rather more attractively. | ||
|
|
||
| Next, Tailwind needs to be able to find all Django's templates so it can target them. We'll |
There was a problem hiding this comment.
What is this next work supposed to achieve? I don't see any difference in behaviour or appearance as a result. It's not clear to me what exactly calls that management command, or when.
There was a problem hiding this comment.
When one runs the npx tailwind ... command with this setup, it will then shell out the management command to get the full list of templates from Django.
In my own projects I use django-compressor to wrap this up (but have that on the backlist to write up)
I'm thinking of shipping a default base template, and compiled static files, to avoid all this for people. See #6. (Which this PR is definitely Refs... at the least.)
There was a problem hiding this comment.
Including the <script src="https://cdn.tailwindcss.com"></script> CDN tailwind, makes it just appear nicely straightaway right? (I didn't run it yet.)
(That's not recommended for production, but it may be OK to defer complexity here... — perhaps with a note saying so. 🤔)
docs/source/tutorial.rst
Outdated
|
|
||
| You notice that the page is now rendered rather more attractively. | ||
|
|
||
| Next, Tailwind needs to be able to find all Django's templates so it can target them. We'll |
There was a problem hiding this comment.
When one runs the npx tailwind ... command with this setup, it will then shell out the management command to get the full list of templates from Django.
In my own projects I use django-compressor to wrap this up (but have that on the backlist to write up)
I'm thinking of shipping a default base template, and compiled static files, to avoid all this for people. See #6. (Which this PR is definitely Refs... at the least.)
docs/source/tutorial.rst
Outdated
|
|
||
| You notice that the page is now rendered rather more attractively. | ||
|
|
||
| Next, Tailwind needs to be able to find all Django's templates so it can target them. We'll |
There was a problem hiding this comment.
Including the <script src="https://cdn.tailwindcss.com"></script> CDN tailwind, makes it just appear nicely straightaway right? (I didn't run it yet.)
(That's not recommended for production, but it may be OK to defer complexity here... — perhaps with a note saying so. 🤔)
Co-authored-by: Carlton Gibson <[email protected]>
There was a problem hiding this comment.
Hey @evildmp — right, home 🏡 😊
I've adjusted the end of the tutorial to stop once you're loading Tailwind from the CDN, and then point to the more detailed guide. (It's such a tar-pit: getting tailwind to pick up all Django's templates via the loader is a whole separate topic I think.)
I'm going to merge and deploy this now — I think it's a great addition. Thank you!
Welcome aboard! ⛵️
No description provided.