Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📱 Resolve Pre Tag Overflow Issue on Mobile Devices #1611

Merged

Conversation

kunalkeshan
Copy link
Contributor

Description

This pull request addresses and resolves the issue of the <pre> tag overflow on mobile devices in the Specifications page. The Gitmoji commit format was overflowing its container, making it difficult to read and causing a poor user experience.

Changes Made

  • Modified the CSS styles in theme.css for the <pre> tag by adding a new .overflow-x-adjusted class to it.
  • Implemented responsive design adjustments to ensure proper formatting on mobile devices.

Screenshots

Before After
Before After

Linked issues

closes #1610

@vercel
Copy link

vercel bot commented Oct 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitmoji ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 6:51pm

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising a PR!

packages/website/src/pages/specification.tsx Show resolved Hide resolved
packages/website/src/utils/theme/theme.css Outdated Show resolved Hide resolved
packages/website/src/utils/theme/theme.css Outdated Show resolved Hide resolved
Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for sending a PR ❤️

@carloscuesta
Copy link
Owner

Oops some tests are failing let me update them

@carloscuesta carloscuesta merged commit abd3391 into carloscuesta:master Oct 10, 2023
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre Tag Overflow in Specifications Page on Mobile Devices
2 participants