Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Extend lock gitmoji to include privacy #1606

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

connorjs
Copy link
Contributor

@connorjs connorjs commented Oct 2, 2023

Extends πŸ”’ :lock: gitmoji to include security and privacy.

Closes #1445


Description

Extends πŸ”’ :lock: gitmoji to include security and privacy.

Linked issues

#1445

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
gitmoji βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 10, 2023 6:55pm

@cruzdanilo
Copy link

can/should the word "fix" be removed from the description? for example, adding a security check is not necessarily fixing an issue.

@connorjs
Copy link
Contributor Author

connorjs commented Oct 3, 2023

What do you suggest we replace it with in that case?

  1. Fix security or privacy issues (current)
  2. Address security or privacy issues
  3. Add or update security or privacy
  4. More...

@connorjs
Copy link
Contributor Author

connorjs commented Oct 3, 2023

Forgot the tag πŸ€¦πŸ»β€β™‚οΈ - Tag @cruzdanilo for above

@cruzdanilo
Copy link

i would like to hear from other people about it. although i like it, i'm not sure about the semantic (breaking?) change.

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Extends πŸ”’ `:lock:` gitmoji to include security and privacy.

Closes carloscuesta#1445
@carloscuesta carloscuesta merged commit d979d9e into carloscuesta:master Oct 10, 2023
2 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji for things related to privacy
3 participants