change twitter to twitter-x icon #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vhoyer
approved these changes
Aug 23, 2023
| @@ -53,6 +53,18 @@ export const IconDefinitions = () => ( | |||
| </g> | |||
| <circle cx="15.1" cy="24.9" r="2.5" fill="#3e4347" /> | |||
| </symbol> | |||
| <symbol id="icon-twitter-x" viewBox="0 0 64 50"> | |||
There was a problem hiding this comment.
We need to take a look at this viewBox since it's not a square and the spacing looks weird in comparison to the star one:
There was a problem hiding this comment.
I think I improved it, but it's mostly been random trial and error on my end. Is there a better way to do this?
There was a problem hiding this comment.
Yes! It improved a bit, problem is that the X logo is not a perfect square so we need to do some adjustments into it 👀
But looks better now so let's merge it!
auto-merge was automatically disabled
August 24, 2023 19:25
Head branch was pushed to by a user without write access
I know right 😢 |
Co-authored-by: Carlos Cuesta <[email protected]>
willyamacaroni
force-pushed
the
willyam/update_twitter_icon
branch
from
d8cc4da to
68266f9
Compare
carloscuesta
approved these changes
Aug 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After the rebranding of twitter to X by Elon Musk, it might be pertinent to update the "tweet" button. It does look a bit off and twitter still has more brand recognition than X, but I leave that up to the maintainers of gitmoji to pick what they prefer.
Linked issues
#1563