🚸 Better wrap lines for gitmoji codes for better readability #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leads to better readability
vhoyer
force-pushed
the
better-break-gitmoji-code
branch
from
94a6d64 to
db76b52
Compare
vhoyer
changed the title
vhoyer
changed the title
| @@ -49,4 +57,13 @@ const Gitmoji = (props: Props) => { | |||
| ) | |||
| } | |||
|
|
|||
| const replaceWithJSX = (text: string, find: string, replace: JSX.Element) => { | |||
There was a problem hiding this comment.
Hey! Should we rename this fn to explain better what is doing? (Facilitating the readability of the emoji codes using wbr tags?
There was a problem hiding this comment.
sorry for being MIA, I've been really busy recently, I will come back helping as soon as possible, tho, much love ❤️
There was a problem hiding this comment.
No worries! Was just a small comment happy to merge this 😊
Hope everything is good ❤️
carloscuesta
approved these changes
Mar 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
fixes #1331 (partially)