✨ Export gitmojis as CJS and ESM
#1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployment failed with the following error: |
carloscuesta
force-pushed
the
export-gitmojis-cjs-and-esm
branch
from
30265a0 to
a4b7164
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
carloscuesta
force-pushed
the
export-gitmojis-cjs-and-esm
branch
from
a4b7164 to
62d39a9
Compare
carloscuesta
force-pushed
the
export-gitmojis-cjs-and-esm
branch
from
659a3a8 to
6b4c969
Compare
carloscuesta
changed the title
CJS and ESM
carloscuesta
changed the title
CJS and ESMgitmojis as CJS and ESM
vhoyer
approved these changes
Jan 17, 2023
|
nice, but I think #1282 would come in handy, especially to the help of people new to the project |
|
Of course @vhoyer!! Thanks for raising that PR, I added nodemon to the gitmojis package but I was not aware of the |
|
Let's ship this 🚀 |
|
Glad to help |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hey! 👋🏼
This PR exports the
gitmojispackage both as aCJSandESMmodules.Drawbacks
Fixed in #1282 (refresh is a bit slower but works!)
Linked issues
Fixes #1279
Eventually we will deprecate
CJSbut for now keeping both versions for backwards compatibility.