-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💄 Update UI Toolbar Button #1232
Merged
carloscuesta
merged 3 commits into
carloscuesta:master
from
FelixLgr:fix/update-button-css
Dec 29, 2022
Merged
💄 Update UI Toolbar Button #1232
carloscuesta
merged 3 commits into
carloscuesta:master
from
FelixLgr:fix/update-button-css
Dec 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending a PR! 😬
src/components/GitmojiList/Toolbar/ListModeSelector/styles.module.css
Outdated
Show resolved
Hide resolved
src/components/GitmojiList/Toolbar/ThemeSelector/styles.module.css
Outdated
Show resolved
Hide resolved
src/components/GitmojiList/Toolbar/ListModeSelector/styles.module.css
Outdated
Show resolved
Hide resolved
src/components/GitmojiList/Toolbar/ThemeSelector/styles.module.css
Outdated
Show resolved
Hide resolved
FelixLgr
force-pushed
the
fix/update-button-css
branch
from
December 29, 2022 15:16
42f9bc4
to
bc05aa9
Compare
carloscuesta
approved these changes
Dec 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Thanks 🙏🏼
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dark mode and the light mode are not coherent. When you change the mode you can see that the buttons on the right of the search are in one case in over-brightness and in the other not.
I added the CSS attributes to be coherent. I took the opportunity to remove one that was duplicated.
Linked issues
Close #1231
Result