Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dependencies to dev dependencies #1103

Merged
merged 2 commits into from
Jul 29, 2022

Conversation

bryanjtc
Copy link
Contributor

@bryanjtc bryanjtc commented Jul 27, 2022

The end user doesn't need to install this dependencies. These are only used for the website.
Fixes: #1102

Description

I moved the dependencies to dev dependencies.
I only updated the package.json. The yarn.lock also needs updating.

Tests

  • All tests passed.

The end user doesn't need to install this dependencies. These are only used for the website.
@vercel
Copy link

vercel bot commented Jul 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
gitmoji ✅ Ready (Inspect) Visit Preview Jul 28, 2022 at 3:40PM (UTC)

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Can you update the lockfile as well?

@bryanjtc
Copy link
Contributor Author

@carloscuesta Done

@carloscuesta carloscuesta merged commit 3c386c4 into carloscuesta:master Jul 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings while installing gitmojis
2 participants