Add solutions for advent of code 2024 day 1 to examples/.
#4673
+8,166
−11,416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove repeated definitions of `i32` operations that were causing duplicate name errors. - Build object files for the prelude and link against them when building `carbon_binary` rules.
Set their parent as the current package and mark them as being closed so that we can later recognize them as packages. Fixes pretty-printing of an indirectly imported `Core.Int`.
This adds two new builtins to the toolchain: `print.char` and `read.char`, which map to the libc functions `putchar` and `getchar`. Also fixes a bug where global variables would create LLVM variable declarations, not definitions, resulting in link errors.
|
Depends on #4644. |
github-actions
bot
added
documentation
jonmeow
reviewed
Dec 12, 2024
| var EOF: i32 = -(1 as i32); | ||
| var push_back: i32 = EOF; | ||
|
|
||
| fn ReadCharRaw() -> i32 = "read.char"; |
There was a problem hiding this comment.
Can these be moved out of examples/ and into a library?
| return from - 1; | ||
| } | ||
|
|
||
| fn Quicksort(p: [i32; 1000]*, from: i32, to: i32) { |
There was a problem hiding this comment.
Had you considered moving Quicksort out to a library?
There was a problem hiding this comment.
I had, but import_ref can't import array types yet, so this is blocked on that.
There was a problem hiding this comment.
And now moved out into a library.
jonmeow
reviewed
Dec 12, 2024
| @@ -0,0 +1,142 @@ | |||
| // Part of the Carbon Language project, under the Apache License v2.0 with LLVM | |||
There was a problem hiding this comment.
These files don't really have much in terms of documentation. Would it be worth at least adding a README.md explaining what you're doing here?
jonmeow
reviewed
Dec 12, 2024
|
Split the bugfix out to #4674. |
prelude. Move the existing `Print` there too.
jonmeow
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support these examples, this adds two new builtins to the toolchain:
print.charandread.char, which map to the libc functionsputcharandgetchar.