Basic name poisoning support #4654
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbon-language#4622 When using an unqualified name disallow using that name in all scopes that would make it ambiguous in retrospect. Doesn't include support for poisoning when importing (see new test for that with TODO). Implemented by introduce `InstId::PoisonedName` and entries with it to `NameScope`.
jonmeow
reviewed
Dec 9, 2024
toolchain/check/testdata/function/declaration/no_prelude/name_poisoning.carbon
Show resolved
Hide resolved
toolchain/check/testdata/function/declaration/no_prelude/name_poisoning.carbon
Outdated
Show resolved
Hide resolved
toolchain/check/testdata/function/declaration/no_prelude/name_poisoning.carbon
Show resolved
Hide resolved
toolchain/check/testdata/function/declaration/no_prelude/name_poisoning.carbon
Outdated
Show resolved
Hide resolved
* Use `llvm::SmallVector` instead of `std::vector`. * Put `DeclNameStack::NameContext::State::Poisoned` before `DeclNameStack::NameContext::State::Unresolved`. * Fix comment style and grammar. * Remove `InstId::PoisonedNameIndex`. * Use "non-poisoned" instead of "non poisoned".
jonmeow
reviewed
Dec 10, 2024
jonmeow
reviewed
Dec 11, 2024
…ote to the place where the name is declared after it was poisoned.
|
Can you take a look at the test failures? |
Sure, I couldn't reproduce this locally and couldn't find a diff between what I run locally and the failure. |
|
It's probably only failing after merging with trunk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4622
When using an unqualified name, disallow declaring that name in all scopes that would make it ambiguous in retrospect.
Doesn't include support for poisoning in
impl library(see new test for that with TODO).Implemented by introduce
InstId::PoisonedNameand entries with it toNameScope.