Singular extern declarations
#3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonmeow
added
proposal
jonmeow
force-pushed
the
proposal-extern
branch
7 times, most recently
from
e5f5c2f to
8c2f391
Compare
github-actions
bot
added
proposal rfc
chandlerc
reviewed
May 24, 2024
josh11b
reviewed
May 24, 2024
zygoloid
reviewed
Jun 4, 2024
chandlerc
reviewed
Jul 13, 2024
There was a problem hiding this comment.
Thanks, overall I think the proposal looks great. Added some super minor suggestions in line, but they don't seem to be very significant.
I did suggest another attempt at writing up rationale for the alternative, although I'm not confident in the words I ended up with either. Maybe you or others have better ways of summarizing this.
In general, with whatever improvements to the alternative syntax rationale we converge on, I'm happy with this landing.
Co-authored-by: Chandler Carruth <[email protected]>
Co-authored-by: Chandler Carruth <[email protected]>
jonmeow
force-pushed
the
proposal-extern
branch
3 times, most recently
from
a121a62 to
0564943
Compare
zygoloid
reviewed
Jul 24, 2024
|
FYI, added extended notes on syntactic matching (specifically, why it won't apply for |
chandlerc
approved these changes
Aug 8, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Trying to pull in key elements of #3762, #3763, and #3980 (decl matching and `extern`, essentially). These aren't specific to any particular declaration type, but are common to entities, so suggesting a new doc oriented on that. There's probably more that could be said here, I'm just focused on getting the recent formal discussion mirrored into the design. --------- Co-authored-by: josh11b <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each entity is restricted to one, optional
externdeclaration. If used, it must be imported by the defining library. The defining library annotates the existence of anexternwith thehas_externmodifier.