Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark what is provisional in the design overview #1984

Merged
merged 8 commits into from
Aug 11, 2022

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Aug 10, 2022

Also references were added to clarify that some features are not provisional.

@josh11b josh11b requested a review from jonmeow August 10, 2022 23:55
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me. Want to give a chance for some others to check that they don't spot missing places here.

Comment on lines +1000 to +1002
> **Note:** The semantics of assignment are provisional. See pending proposal
> [#821: Values, variables, pointers, and references](https://github.com/carbon-language/carbon-lang/pull/821).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it even makes sense to include #821 vs. just marking as provisional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It leaves a breadcrumb to see where the content from the README came from, and where to go to read more.

docs/design/README.md Outdated Show resolved Hide resolved
docs/design/README.md Show resolved Hide resolved
docs/design/README.md Outdated Show resolved Hide resolved
Co-authored-by: Jon Ross-Perkins <[email protected]>
docs/design/README.md Outdated Show resolved Hide resolved
@josh11b josh11b merged commit 09e4417 into carbon-language:trunk Aug 11, 2022
@josh11b josh11b deleted the provisional branch August 11, 2022 21:50
@chandlerc chandlerc added the documentation An issue or proposed change to our documentation label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation An issue or proposed change to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants