-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Tearsheet): implement focus trapping within tearsheets in V1 #4133
Merged
davidmenendez
merged 15 commits into
carbon-design-system:main_v1
from
makafsal:tearsheet-focus-trap-3499-v1
Feb 9, 2024
Merged
fix(Tearsheet): implement focus trapping within tearsheets in V1 #4133
davidmenendez
merged 15 commits into
carbon-design-system:main_v1
from
makafsal:tearsheet-focus-trap-3499-v1
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change in focus claim function for stacked tearsheets handle tab key press operation properly to navigate through fields
✅ Deploy Preview for v1-carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ack to avoid stale closure
…m-products into tearsheet-focus-trap-3499-v1
amal-k-joy
previously approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine and seems to be working.
davidmenendez
previously approved these changes
Feb 6, 2024
makafsal
dismissed stale reviews from amal-k-joy and davidmenendez
via
February 7, 2024 06:51
b2e6e11
Implemented the |
elycheea
reviewed
Feb 7, 2024
davidmenendez
previously approved these changes
Feb 8, 2024
davidmenendez
approved these changes
Feb 9, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3499
change in focus claim function for stacked tearsheets
handle tab key press operation properly to navigate through fields
V2 PR: #4129