Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tearsheet): implement focus trapping within tearsheets in V1 #4133

Conversation

makafsal
Copy link
Member

Contributes to #3499

change in focus claim function for stacked tearsheets
handle tab key press operation properly to navigate through fields

V2 PR: #4129

change in focus claim function for stacked tearsheets
handle tab key press operation properly to navigate through fields
@makafsal makafsal added the version: 1 Carbon 10 / v1 label Jan 22, 2024
@makafsal makafsal requested a review from a team as a code owner January 22, 2024 17:37
Copy link

netlify bot commented Jan 22, 2024

Deploy Preview for v1-carbon-for-ibm-products ready!

Name Link
🔨 Latest commit 312cad9
🔍 Latest deploy log https://app.netlify.com/sites/v1-carbon-for-ibm-products/deploys/65c64e18642ffa0008fbb529
😎 Deploy Preview https://deploy-preview-4133--v1-carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

amal-k-joy
amal-k-joy previously approved these changes Jan 30, 2024
Copy link
Contributor

@amal-k-joy amal-k-joy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine and seems to be working.

davidmenendez
davidmenendez previously approved these changes Feb 6, 2024
@makafsal makafsal dismissed stale reviews from amal-k-joy and davidmenendez via b2e6e11 February 7, 2024 06:51
@makafsal
Copy link
Member Author

makafsal commented Feb 7, 2024

Implemented the useFocus() hook in this branch as well.
Path: packages/ibm-products/src/global/js/hooks/useFocus.js

davidmenendez
davidmenendez previously approved these changes Feb 8, 2024
@davidmenendez davidmenendez merged commit fcbee74 into carbon-design-system:main_v1 Feb 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: 1 Carbon 10 / v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants