make compilation an environmental flag, not the default #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, sobelow looks awesome. 👍 |
carakan
requested changes
Jul 25, 2017
lib/pronto/credo_runner.rb
Outdated
| @@ -10,7 +10,7 @@ def initialize(_, _) | |||
| def run | |||
| return [] unless @patches | |||
|
|
|||
| compile | |||
| compile if ENV["PRONTO_CREDO_COMPILE"] | |||
There was a problem hiding this comment.
great! could you add a value to verify? for example: compile if(ENV["PRONTO_CREDO_COMPILE"] == 1)
|
cool feature @veverkap I added one suggestion, let me know if is possible to make this change. |
|
@carakan yes, added the change |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our CI runs are slowing down unnecessarily because of the compilation step.
In our case, compilation is actually unneeded because we
mix do deps.get, compileearlier in the build.Could we switch to having an environmental flag to toggle this?