Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow getElementsByClassName to accept a whitespace-separated list #1618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylehalleman
Copy link

getElementsByClassName can accept a whitespace-separated list of classNames (see MDN and spec).

The current implementation prepends . to the className in querySelectorAll (i.e., classOne classTwo classThree -> .classOne classTwo classThree). This PR splits the className string by any amount of whitespace, then prepends a . to each separated className, then joins to make a single query to querySelectorAll (e.g., classOne classTwo classThree -> .classOne.classTwo.classThree).

Added test to confirm this new functionality.

@personalyisus
Copy link

This would be a solution for #1551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants