Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#1565] Strictly check the type of blob parameters #1575

Merged
merged 5 commits into from
Nov 6, 2024

Conversation

btea
Copy link
Contributor

@btea btea commented Nov 2, 2024

fix #1565

@btea btea requested a review from capricorn86 as a code owner November 2, 2024 06:40
capricorn86
capricorn86 previously approved these changes Nov 6, 2024
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @btea! ⭐

I changed to use TypeError from Window, as BrowserExceptionObserver can then detect the origin of the error

@capricorn86 capricorn86 merged commit 6ff0d8f into capricorn86:master Nov 6, 2024
3 checks passed
@btea btea deleted the fix/vertify-blob-type branch November 7, 2024 00:13
@btea
Copy link
Contributor Author

btea commented Nov 7, 2024

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileReader never throws errors
2 participants