fix: [#1526] handle missing symbol props in HTMLSelectElement #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry
force-pushed
the
fix/missing-symbol-properties-HTMLSelectElement
branch
from
8278dcb to
63ed89a
Compare
capricorn86
approved these changes
Sep 1, 2024
saga
pushed a commit
to dalian-js/happy-dom
that referenced
this pull request
Sep 3, 2024
…erve again after disconnecting in MutationObserver (capricorn86#1525)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #1526 and adds a couple of tests to ensure no regression can happen.
I took the main fix here from
HTMLFormElement:happy-dom/packages/happy-dom/src/nodes/html-form-element/HTMLFormElement.ts
Line 99 in 20b520a
Let me know if any changes are needed.