Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrating to happy-dom raises some issue #1558

Closed
eduardhasanaj opened this issue Sep 30, 2024 · 1 comment · Fixed by #1602
Closed

Migrating to happy-dom raises some issue #1558

eduardhasanaj opened this issue Sep 30, 2024 · 1 comment · Fixed by #1602
Assignees
@capricorn86
Labels
bug Something isn't working

Comments

@eduardhasanaj
Copy link

I am trying to use happy-dom in an existing test suite with 1000 but I get following error for some of the tests:

  1. DOMException: Failed to execute 'matches' on 'HTMLButtonElement': 'button:not' is not a valid selector.
  2. TypeError: Cannot set properties of null (setting 'onclick')
  3. ReferenceError: $ is not defined: the code run in browser without errors as I checked console.

Steps to reproduce the behavior:
I don't understand some of the issues like $ Reference Error but first issue is caused by following query selector

el.querySelectorAll("button:not([type]")
@eduardhasanaj eduardhasanaj added the bug Something isn't working label Sep 30, 2024
@ianlet ianlet mentioned this issue Oct 7, 2024
Closed
@capricorn86 capricorn86 self-assigned this Nov 12, 2024
capricorn86 added a commit that referenced this issue Nov 12, 2024
@capricorn86
fix: [#1558] Fixes bug where psuedo selectors without an ending prant…
7ec5d03 
…hese result in invalid selector error
@capricorn86 capricorn86 linked a pull request Nov 12, 2024 that will close this issue
fix: [#1558] Fixes bug where psuedo selectors without an ending parentheses throws an invalid selector error, but should be considered as valid #1602
Merged
capricorn86 added a commit that referenced this issue Nov 12, 2024
@capricorn86
fix: [#1558] Fixes bug where psuedo selectors without an ending prant…
dc06801 
…hese result in invalid selector error (#1602)
@capricorn86
Copy link
Owner

Thank you for reporting @eduardhasanaj! 🙂

I believe this has been fixed now in the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@capricorn86 capricorn86

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@capricorn86 @eduardhasanaj