🐞 fix: Link libc++.a for mac

caoccao · Nov 14, 2024 · 731515d · 731515d
1 parent d9d84ba
commit 731515d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
@@ -308,7 +308,7 @@ elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR CMAKE_SYSTEM_NAME STREQUAL "Android
             # This is a patch build.
             # https://github.com/abseil/abseil-cpp/blob/master/CMake/README.md
             add_subdirectory(${V8_DIR}/third_party/abseil-cpp ${V8_RELEASE_DIR}/third_party/abseil-cpp)
-            target_link_libraries(Javet PUBLIC absl::base absl::time)
+            target_link_libraries(Javet PUBLIC -lc++ absl::base absl::time)
         endif()
         if(DEFINED NODE_DIR)
             list(APPEND includeDirs

diff --git a/docs/release_notes/release_notes_4_0.rst b/docs/release_notes/release_notes_4_0.rst
@@ -7,6 +7,7 @@ Release Notes 4.0.x - 4.1.x
 
 * Upgraded Node.js to ``v22.11.0`` `(2024-10-29) <https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.11.0>`_
 * Upgraded V8 to ``v13.1.201.8`` (2024-11-11)
+* Upgraded clang to v20 for V8 mode on MacOS
 * Switched to core dependency + individual native dependency
 * Supported ``Float16Array``
 * Added ``Float16``