DPE-3364 DPE-3563 fix: skip relation-changed if upgrading #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deusebio
changed the title
zmraul
approved these changes
Feb 13, 2024
deusebio
changed the title
deusebio
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
I have tested positively these changes, making sure that they address the points 2 and 3 of the related issue.
Point 1 is more general and applies to any charm downloaded from the store. Interestingly, the failed units and logs did not show up when using a local charm from this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
fix: centralise compatibility patches during upgradestruststore-passwordunit-data, which was not present in older revisionsfix: skip relation-changed if not idleconfig_changedsetting of config items is now skipped, avoiding issues with missing new relation-data itemsupdate-status, meaning that the charm will stayBlockedStatusif upgrade failed