Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly remove old zNodes during relation-broken #108

Merged
merged 5 commits into from
Jan 25, 2024
Merged

fix: properly remove old zNodes during relation-broken #108

merged 5 commits into from
Jan 25, 2024

Conversation

marcoppenheimer
Copy link
Contributor

@marcoppenheimer marcoppenheimer commented Jan 25, 2024 •
edited
Loading

Changes Made

fix: properly remove old zNodes during relation-broken

  • Mistake from the refactor meant that on relation-broken events, the chroot from the broken Application would still exist, with it's zNodes surviving the break
  • Removing a Kafka relation, then re-relating, would persist the original ACLs (e.g relation-6) on child nodes (e.g /kafka/config/users) sharing the same parent (e.g /kafka)
  • This meant that the related application couldn't authenticate to the new zNodes

zmraul
zmraul approved these changes Jan 25, 2024
View reviewed changes
src/managers/quorum.py Show resolved Hide resolved
@zmraul zmraul mentioned this pull request Jan 25, 2024
Merged
@marcoppenheimer marcoppenheimer merged commit 5cc7652 into main Jan 25, 2024
14 of 15 checks passed
@marcoppenheimer marcoppenheimer deleted the fix/actually_drop_chroots branch January 25, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmraul zmraul zmraul approved these changes

@deusebio deusebio deusebio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoppenheimer @deusebio @zmraul