[DPE-2900] Cross-region async replication integration tests #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…tion-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…tion-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…tion-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
This was referenced Apr 23, 2024
marceloneppel
requested review from
delgod,
taurus-forever,
dragomirp and
lucasgameiroborges
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…tion-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…tion-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
taurus-forever
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Thank you! Excellent!
P.S. please fire a followup ticket/PR for the same issue as described here: canonical/postgresql-operator#453 (review)
…ation Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…tion-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
|
Not an issue with the PR, but I don't think we'll see details about the second model in the |
dragomirp
approved these changes
May 2, 2024
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…tion-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
I agree. That would help us to understand what's happening in the second model when something fails. |
…ation-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…ation-integration-tests Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There are no integration tests for cross-region async replication.
Solution
Add integration tests for the following scenarios:
Some of the helper functions were changed to accommodate checks on multiple models, like when checking whether writes are increasing (to now check it in both clusters).