Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup common non-namespaced resources (Closes #4747) #4779

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LoniasGR
Copy link

@LoniasGR LoniasGR commented Dec 10, 2024

Summary

This MR adds some common non-namespaced APIs to be removed when doing a microk8s reset. I also refactored the code a bit to be more consistent and fixed the help message for destroy storage.

Closes #4747
References #3243 #4297

Changes

I added the removal of CRDs to a function and created a function for the rest of the non-namespaced APIs.

Testing

I ran the following steps:

  1. Setup microk8s cluster.
  2. Install ingress-nginx-controller as described here.
      helm upgrade --install ingress-nginx ingress-nginx \
         --repo https://kubernetes.github.io/ingress-nginx \
        --namespace ingress-nginx --create-namespace
  3. Run microk8s reset.
  4. Everything was removed.

Possible Regressions

Checklist

  • Read the contributions page.
  • Submitted the CLA form, if you are a first time contributor.
  • The introduced changes are covered by unit and/or integration tests.

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

microk8s reset does not completely reset the cluster
1 participant