Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage: Improve volume name validation in CreateCustomVolumeFromBackup #13263

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

tomponline
Copy link
Member

We shouldn't trust the volume names in the backup's index.yaml file.

@tomponline tomponline requested a review from roosterfish April 5, 2024 15:13
@tomponline tomponline self-assigned this Apr 5, 2024
@tomponline tomponline force-pushed the tp-volume-validation branch from de2b79e to b0ad804 Compare April 5, 2024 15:14
Copy link
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There looks to be a temporary error installing some dependencies, but the changes itself are looking good.

@tomponline tomponline merged commit b9dde2a into canonical:main Apr 5, 2024
25 of 28 checks passed
@tomponline tomponline deleted the tp-volume-validation branch June 15, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants