Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure uid, gid, and mode are valid during parsing #13230

Merged
merged 3 commits into from
Mar 28, 2024

Conversation

MggMuggins
Copy link
Contributor

And add some rigor to the documentation around these fields. This came up during #13193

This prevents passing values larger than 32 bits as uid/gid, and
consistently truncates the mode.

Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
Signed-off-by: Wesley Hershberger <[email protected]>
@MggMuggins MggMuggins requested a review from tomponline as a code owner March 27, 2024 21:58
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Mar 27, 2024
Copy link

Heads up @ru-fu - the "Documentation" label was applied to this issue.

@MggMuggins MggMuggins marked this pull request as draft March 27, 2024 22:24
@MggMuggins MggMuggins marked this pull request as ready for review March 27, 2024 22:28
@tomponline tomponline merged commit 4000c20 into canonical:main Mar 28, 2024
29 checks passed
@MggMuggins MggMuggins deleted the permissions-parsing branch March 29, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants