Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: add notification for doc PRs #13201

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

ru-fu
Copy link
Contributor

@ru-fu ru-fu commented Mar 22, 2024

Update the triaging action to notify specified recipients when a specific label is added to a PR or issue.

Currently, it's configured to notify me of all Documentation issues/PRs, but it can easily be expanded. ;)

Not sure if you are okay with doing this, or if there's a better way to do it, but it would make my life easier. ;)
We could probably put it in a different workflow as well (instead of reusing the triaging workflow), but I feel it kinda fits in there.

@ru-fu ru-fu requested a review from tomponline as a code owner March 22, 2024 14:34
@@ -17,3 +22,20 @@ jobs:
with:
repo-token: "${{ secrets.GITHUB_TOKEN }}"
sync-labels: true
notify:
name: Notify
runs-on: ubuntu-20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use 22.04 as standard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just ubuntu-latest?
I had that first, but then I assumed there was probably a reason to use 20.04 on the original workflow ... but checking now, I see that hasn't been touched for two years, so there's probably no reason after all. ;)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use 22.04 everywhere else. While I wouldn't mind ubuntu-latest for this workflow, the rational for specifying which version was used in other workflow is that we want to control/be aware when the underlying distro changes as that has bigger impact on our tests for example.

ubuntu-latest typically moves to the new LTS few months after it's official release.

Update the triaging action to notify specified recipients when a
specific label is added to a PR or issue.

Currently, it's configured to notify me of all Documentation
issues/PRs, but it can easily be expanded. ;)

Signed-off-by: Ruth Fuchss <[email protected]>
@tomponline tomponline merged commit 9d419c0 into canonical:main Mar 26, 2024
26 of 27 checks passed
@simondeziel
Copy link
Member

@ru-fu this notify action apparently is missing/not finding a required YAML file, see https://github.com/canonical/lxd/actions/runs/8444823531/job/23131042647?pr=13219

@ru-fu
Copy link
Contributor Author

ru-fu commented Mar 27, 2024

@ru-fu this notify action apparently is missing/not finding a required YAML file, see https://github.com/canonical/lxd/actions/runs/8444823531/job/23131042647?pr=13219

Argh ... I had the same in testing (horrible documentation for that action ...), but fixed it there. And apparently got myself completely confused when copying the changes over. Let's try again ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants