Auth: Pre-check permissions when performing bulk state update. #13155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, state updates invoked against all instances in a project were applied partially - depending on the permissions of the caller. The commit checks permissions for all instances in the project and enforces that the caller has permission to update all of them before continuing. Signed-off-by: Mark Laing <[email protected]>
markylaing
changed the title
18 tasks
roosterfish
approved these changes
Mar 15, 2024
tomponline
approved these changes
Mar 15, 2024
tomponline
reviewed
Mar 15, 2024
| if !userHasPermission(entity.InstanceURL(inst.Project().Name, inst.Name())) { | ||
| return response.Forbidden(nil) |
There was a problem hiding this comment.
Can we add a better error to the Forbidden response?
There was a problem hiding this comment.
I wasn't sure what the response should be as we're attempting not to make any resources discoverable...
Maybe User does not have entitlement "can_update_state" for all instances? But then they will know that there are other instances in the project 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, state updates invoked against all instances in a project were applied partially - depending on the permissions of the caller. The commit checks permissions for all instances in the project and enforces that the caller has permission to update all of them before continuing.
Partially addresses #12461 - see #12313 (comment)