Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated HasExtension checks #12764

Merged
merged 17 commits into from
Jan 23, 2024
Merged

Replace deprecated HasExtension checks #12764

merged 17 commits into from
Jan 23, 2024

Conversation

MusicDin
Copy link
Member

Replaces HasExtension with CheckExtension API extension checks.

@MusicDin MusicDin requested a review from tomponline as a code owner January 23, 2024 13:34
tomponline
tomponline requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a wording change that has been scooped up in a CheckExtension change

@MusicDin MusicDin force-pushed the fix/extension-checks branch from b28edb8 to 2c2edca Compare January 23, 2024 15:39
tomponline
tomponline requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit message client/lxd_instnaces: Fix typo in api extension check error message

MusicDin added 12 commits January 23, 2024 16:48
@MusicDin
client/lxd_instances: Fix typo in api extension check error message
60db116 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_network_acls: Replace HasExtension with CheckExtension
fbf8db6 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_network_forwards: Replace HasExtension with CheckExtension
b231c1c 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_network_peer: Replace HasExtension with CheckExtension
4f991c2 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_network_zones: Replace HasExtension with CheckExtension
b24a12c 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_networks: Replace HasExtension with CheckExtension
d7fcb94 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_projects: Replace HasExtension with CheckExtension
2a73c78 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_server: Replace HasExtension with CheckExtension
1f39fdf 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_storage_buckets: Replace HasExtension with CheckExtension
c71586b 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_storage_pools: Replace HasExtension with CheckExtension
23ad4ab 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_storage_volumes: Replace HasExtension with CheckExtension
a485dc2 
Signed-off-by: Din Music <[email protected]>
@MusicDin
client/lxd_warnings: Replace HasExtension with CheckExtension
cd42b6f 
Signed-off-by: Din Music <[email protected]>
@MusicDin MusicDin force-pushed the fix/extension-checks branch from 2c2edca to cd42b6f Compare January 23, 2024 15:49
@MusicDin
Copy link
Member Author

Ahh, typo in typo fix hehe. Good spot, thanks :)

@tomponline tomponline merged commit a890222 into canonical:main Jan 23, 2024
26 checks passed
@MusicDin MusicDin deleted the fix/extension-checks branch January 24, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline tomponline approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MusicDin @tomponline