test/lint: Always fetch the target branch if it cannot be found. #12741
Conversation
markylaing
force-pushed
the
fetch-target-branch
branch
from
42afdbe to
cb941af
Compare
Previously this was only performed when the GITHUB_BEFORE environment variable was set. Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
fetch-target-branch
branch
3 times, most recently
from
bc5b8e4 to
d4028d0
Compare
Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
fetch-target-branch
branch
from
d4028d0 to
4dac736
Compare
|
@tomponline this seems to be working now. I've changed the script to abort if it doesn't find a revision to check against, otherwise no lint errors will be raised. I am quite confused as to how we haven't come across this before. It's possible that we just didn't notice the warning and nothing has been linted with golangci for quite some time 😢 |
Indeed this is from the next PR that changed any Go code (#12649), it was in December: https://github.com/canonical/lxd/actions/runs/7164995944/job/19506095032#step:14:19 |
|
I'm glad I opportunistically noticed and mentioned it then :) |
Previously this was only performed when the GITHUB_BEFORE environment variable was set.