Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply the snapshots.pattern option for manual custom volume snapshot #12717

Merged

Conversation

gabrielmougard
Copy link
Contributor

closes #12630

@gabrielmougard gabrielmougard self-assigned this Jan 10, 2024
@gabrielmougard gabrielmougard marked this pull request as ready for review January 10, 2024 08:17
roosterfish
roosterfish previously approved these changes Jan 11, 2024
Copy link
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the error handling removal that needs attending to, other than that LGTM!

@tomponline tomponline merged commit de3f21e into canonical:main Jan 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom storage volume snapshot naming does not work with snapshots.pattern config
3 participants