metrics: Fix label merging in metric sets #12474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the Merge function to apply any missing labels from the receiver to all samples from the argument. This fixes an issue where filesystem stats would be missing certain labels which were not explicitly set for the filesystem stats metric set. Signed-off-by: Thomas Hipp <[email protected]>
simondeziel
reviewed
Oct 27, 2023
Signed-off-by: Thomas Hipp <[email protected]>
simondeziel
approved these changes
Oct 30, 2023
tomponline
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the Merge function to apply any missing labels from the
receiver to all samples from the argument.
This fixes an issue where filesystem stats would be missing certain
labels which were not explicitly set for the filesystem stats metric
set.