Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exec: Log error from io.Copy #12443

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Exec: Log error from io.Copy #12443

merged 4 commits into from
Oct 24, 2023

Conversation

tomponline
Copy link
Member

No description provided.

…teractive exec

As there was also an issue with background processes preventing lxc exec from returning
after main process ended if they were producing no output.

Signed-off-by: Thomas Parrott <[email protected]>
And log error of io.Copy().

Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
@tomponline tomponline marked this pull request as ready for review October 23, 2023 15:32
Copy link
Member

@MusicDin MusicDin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it locally. LGTM

@tomponline tomponline merged commit 8e364f9 into canonical:main Oct 24, 2023
22 of 25 checks passed
@tomponline tomponline deleted the tp-exec branch October 24, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants