lxd/firewall: Fix nftables ACL template #12423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Network interface name must be double-quoted to avoid
collisions with the nftables syntax.
For example a bridge network called `rt` will cause the following error prior to this commit:
```
Error: syntax error, unexpected rt
iifname rt jump acl.rt
^^
```
when trying to set ACL:
`lxc network set rt security.acls="rt-acl"`
because `rt` is a restricted token in the nftables syntax:
https://wiki.nftables.org/wiki-nftables/index.php/Quick_reference-nftables_in_10_minutes#Rt
Signed-off-by: Rafal Borczuch <[email protected]>
tomponline
approved these changes
Oct 20, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network interface name must be double-quoted to avoid collisions with the nftables syntax.
For example a bridge network called
rtwill cause the following error prior to this commit:when trying to set ACL:
lxc network set rt security.acls="rt-acl"because
rtis a restricted token in the nftables syntax: https://wiki.nftables.org/wiki-nftables/index.php/Quick_reference-nftables_in_10_minutes#Rt