Move certificate cache into new package #12367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
certificate-cache
branch
from
3ef0b6a to
b3a5fe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #12313 we need to access the certificate cache from the
authpackage for the TLS driver. While making this change I also noticed that the certificate cache is not strictly thread safe since the certificates and projects are stored in maps. E.g. It would be possible to get the certificate map within a lock, unlock it, then read/write from/to the map and cause a panic. Additionally, here the length of the certificate map is read without a lock which is may be thread safe but could also be a race condition.This PR moves the certificate cache logic into a new package and adds methods for writing/reading from it safely. The returns maps are copies.