lxd: Fully configure new node from cluster config after it is added. #12347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tomponline I found this while ensuring the openfga config gets set on a new cluster member during the join process. I'm pretty certain that RBAC and Candid auth is not being set on joining members because the config values are coming from the If there is another place where this is all being set then please let me know. I'm not sure how this has never come up before. |
|
@markylaing this is a good catch, thanks, and the way you've approached it looks great to me as it'll be future proof. |
tomponline
reviewed
Oct 5, 2023
tomponline
reviewed
Oct 5, 2023
When a new node is added to the cluster, it should get all cluster config (now present after it joins the cluster db) and apply configuration changes locally. Previously we were attempting to apply changes based on the daemons current cluster config (from state) which did not reflect the full cluster configuration. Additionally, we were only applying a subset of configuration changes. This change utilises the doApi10UpdateTriggers to apply all changes consistently. Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
clustering-renew-config
branch
from
cc5d1af to
1bc3065
Compare
|
I'm not sure why the docs build is failing, nor how to re-trigger it. |
5 tasks
tomponline
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new node is added to the cluster, it should get all cluster config (now present after it joins the cluster db) and apply configuration changes locally.
Previously we were attempting to apply changes based on the daemons current cluster config (from state) which did not reflect the full cluster configuration. Additionally, we were only applying a subset of configuration changes. This change utilises the doApi10UpdateTriggers to apply all changes consistently.