simplestreams: Adds support for incus.tar.xz items #12260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
changed the title
|
@stgraber will you also be switching to |
MusicDin
reviewed
Sep 15, 2023
|
We did in our simplestreams package, yeah, but I'm not aware of anyone ever distributing a combined image so far, so unlikely to matter much. |
tomponline
force-pushed
the
tp-image-incus-support
branch
from
a83fd90 to
a53d7a6
Compare
MusicDin
previously approved these changes
Sep 15, 2023
Thanks I'll add support for it just in case. |
|
@stgraber am I right in thinking LXD/Incus would only need to match the first of either {lxd|incus}.tar.xz or {lxd|incus}_combined.tar.xz for a particular version, and that there would be no expectation to match both combined and non-combined variants for a particular version? |
Also adds support for the new `Requirements` field as an alternative to the existing `LXDRequirements` field. Fixes canonical#12206 Signed-off-by: Thomas Parrott <[email protected]>
tomponline
force-pushed
the
tp-image-incus-support
branch
from
a53d7a6 to
3e9acc4
Compare
|
Yeah, I think that's right |
monstermunchkin
approved these changes
Sep 15, 2023
This was referenced Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds support for the new
Requirementsfield as an alternative to the existingLXDRequirementsfield.This is to maintain LXD's compatibility with the community
images.linuxcontainers.orgimages from theimages:remote in thelxcclient.Fixes #12206
Closes #12232