storage: Use btrfs subvolume list command instead of walking dir to get subvolumes #12258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monstermunchkin
previously requested changes
Sep 15, 2023
…subvolumes Signed-off-by: takonomura <[email protected]>
takonomura
force-pushed
the
faster-get-subvolumes
branch
from
26c8475 to
7ebca54
Compare
tomponline
reviewed
Sep 15, 2023
tomponline
reviewed
Sep 15, 2023
tomponline
approved these changes
Sep 15, 2023
tomponline
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes
getSubvolumesto use commandbtrfs subvolume listinstead of walking the entire tree.It took over three seconds to walk the entire tree in my test environment with a large tree. This can be reduced to a few milliseconds using the command.