Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

instance_exec: Add constraint validation #12219

Conversation

monstermunchkin
Copy link
Contributor

@monstermunchkin monstermunchkin commented Sep 5, 2023

This returns an error if record-output and wait-for-websocket, or
interactive and record-output are used in combination.

Fixes #12216

Signed-off-by: Thomas Hipp [email protected]

@monstermunchkin monstermunchkin force-pushed the issues/12216-exec-api-constraint-validation branch 2 times, most recently from cb45242 to e94ca2f Compare September 5, 2023 17:03
lxd/instance_exec.go Outdated Show resolved Hide resolved
This returns an error if `record-output` and `wait-for-websocket`, or
`interactive` and `record-output` are used in combination.

Fixes canonical#12216

Signed-off-by: Thomas Hipp <[email protected]>
@monstermunchkin monstermunchkin force-pushed the issues/12216-exec-api-constraint-validation branch from e94ca2f to 86896e2 Compare September 5, 2023 17:12
@tomponline
Copy link
Member

Thanks!

@tomponline tomponline merged commit 9753bfc into canonical:main Sep 5, 2023
24 checks passed
@monstermunchkin monstermunchkin changed the title instance_exec: Add contraint validation instance_exec: Add constraint validation Sep 5, 2023
@monstermunchkin monstermunchkin deleted the issues/12216-exec-api-constraint-validation branch September 5, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instance exec api constraint validation
3 participants