-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add guide about virt-v2v #12184
doc: add guide about virt-v2v #12184
Conversation
493a3da
to
04be64b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hm, it's interesting:
I haven't used Bare URLs instead |
@ru-fu is our expert on doc linting 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the linting errors:
The last two were there before but had exceptions defined in https://github.com/canonical/lxd/blob/main/doc/.sphinx/.markdownlint/exceptions.txt
The line numbers changed now, so they need to be updated.
I'm not sure about the first two - there isn't really a reason. The first one might be because virtio-win.iso
could be mistaken as a URL. If that's the case, putting it in quotes (which we need anyway since it's not a word) should fix it. The second is strange - but let's fix the others first, maybe it'll resolve itself by the other changes. ;)
04be64b
to
883c10b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it works in the output (except for the backticks in the summary, see comment).
And the strange linting errors disappeared as well! 🎉
For the two that are left, please update the line numbers in https://github.com/canonical/lxd/blob/main/doc/.sphinx/.markdownlint/exceptions.txt
8e78f23
to
d61e24f
Compare
Add a small example of using virt-v2v to convert Windows VMs to LXD. canonical#12154 Signed-off-by: Alexander Mikhalitsyn <[email protected]>
d61e24f
to
05e1d76
Compare
Now documentation tests/checks are happy! |
Thanks both! |
Add a small example of using virt-v2v to convert Windows VMs to LXD.
Closes #12154