lxd: network.limit-related bugfixes #12170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Aug 22, 2023
|
@mihalicyn did you rebase your branch on main btw as the doc builds are failing? |
When new net device appears on the host special event is generated and put in chNetlinkNetwork channel. We don't want to skip the entire hotplug logic if netprio cgroup is not present. First of all we have appropriate check for netprio cgroup in deviceNetworkPriority() and we should not skip networkAutoAttach. Instead, let's filter out device removal events. Signed-off-by: Alexander Mikhalitsyn <[email protected]>
mihalicyn
force-pushed
the
netprio_cgroup_fix
branch
from
1cfedd0 to
6e104a8
Compare
…etNetworkPriority Signed-off-by: Alexander Mikhalitsyn <[email protected]>
mihalicyn
force-pushed
the
netprio_cgroup_fix
branch
from
6e104a8 to
cfc4312
Compare
tomponline
approved these changes
Aug 22, 2023
tomponline
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#12135 (comment)