Reduce noise in CI/test logs when DEBUG is set #12120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns: > + LXD_DIR=/home/runner/work/lxd/lxd/test/tmp.GTh/938 lxc ls > + LXC_LOCAL=1 lxc_remote ls > + set +x > + eval timeout --foreground 120 /home/runner/go/bin/lxc "ls" --verbose > + timeout --foreground 120 /home/runner/go/bin/lxc ls --verbose Into (one less line): > + LXD_DIR=/home/runner/work/lxd/lxd/test/tmp.GTh/938 lxc ls > + set +x > + eval timeout --foreground 120 /home/runner/go/bin/lxc "ls" --verbose > + timeout --foreground 120 /home/runner/go/bin/lxc ls --verbose Signed-off-by: Simon Deziel <[email protected]>
Trurns: > + LXD_DIR=/home/runner/work/lxd/lxd/test/tmp.GTh/938 lxc ls > + set +x > + eval timeout --foreground 120 /home/runner/go/bin/lxc "ls" --verbose > + timeout --foreground 120 /home/runner/go/bin/lxc ls --verbose Into (one less line): > + LXD_DIR=/home/runner/work/lxd/lxd/test/tmp.GTh/938 lxc ls > + set +x > + timeout --foreground 120 /home/runner/go/bin/lxc ls --verbose Signed-off-by: Simon Deziel <[email protected]>
|
The CI run confirmed that "System tests (1.18.x, standalone, ceph)" logs are now 68k lines so it worked out as expected. |
monstermunchkin
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns:
Into (2 less lines):
While trimming 2 lines for each lxc invocation, might not seem much, I find those 2 lines to be essentially noise.
Also, one of our test outputs ~79k lines which would be reduced by ~11k with that PR so down to ~68k lines. This would make navigating those logs a tad less annoying IMHO.