-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instance name in backup file when importing new instance #12079
Conversation
TestShould I add a test for recovering imported instances (that will ensure the above issue does not happen again)? If so, should I put in ProjectsWhile project in Another (unrelated) issue is when an instance is created in a project, but no instance name is provided. $ lxc launch ubuntu:22.04
Creating the instance
Instance name is: lenient-llama
Starting lenient-llama
$ lxc launch ubuntu:22.04 --project test
Creating the instance
Instance name is: steady-seasnail?project=test
Starting steady-seasnail?project=test
Error: Instance not found
$ lxc launch ubuntu:22.04 c123 --project test
Creating c123
Starting c123 If this is not the expected behavior, I can fix it in another PR? |
Yes please |
Good spot! Lets fix that :) |
Agreed, good idea. It should represent the project its imported into. |
5c13f9b
to
9b9c9cc
Compare
…iple backup file properties Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
Signed-off-by: Din Music <[email protected]>
9b9c9cc
to
c6f15d0
Compare
When new instance is imported, instance and volume names are updated in
backup.yaml
file to match the new instance name.Fixes #12065