Ensures golangci-lint is latest release version in CI

[markylaing]

The PR ensures golangci-lint is the latest version when running in CI. If lint errors occur in CI that a developer did not encounter locally, they can check against the latest version with rm $GOPATH/bin/golangci-lint && make static-analysis.

It looks like the gci linter has changed a little and is unhappy with any files containing GCO. It is possible to reorder the imports to make this pass but I found the change less clear so I have excluded any files containing CGO from gci linting (other linters will still run).

Partially addresses #12011

[tomponline]

It looks like the gci linter has changed a little and is unhappy with any files containing GCO. It is possible to reorder the imports to make this pass but I found the change less clear so I have excluded any files containing CGO from gci linting (other linters will still run).

Can you give us an example of the suggested changes? As excluding the gci linter from CGO files means we can presumably make non-cgo related import ordering changes that would otherwise be flagged by the linter in those files? That doesn't sound good to me if i am interpreting that correctly.

[monstermunchkin]

I wouldn't exclude cgo files for the gci linter, but move the C code to the top.

[markylaing]

It looks like the gci linter has changed a little and is unhappy with any files containing GCO. It is possible to reorder the imports to make this pass but I found the change less clear so I have excluded any files containing CGO from gci linting (other linters will still run).

Can you give us an example of the suggested changes? As excluding the gci linter from CGO files means we can presumably make non-cgo related import ordering changes that would otherwise be flagged by the linter in those files? That doesn't sound good to me if i am interpreting that correctly.

I was just mistaken about this. Yes we can just move the C to the top of the files as @monstermunchkin suggests.

[tomponline]

It looks like the gci linter has changed a little and is unhappy with any files containing GCO. It is possible to reorder the imports to make this pass but I found the change less clear so I have excluded any files containing CGO from gci linting (other linters will still run).

Can you give us an example of the suggested changes? As excluding the gci linter from CGO files means we can presumably make non-cgo related import ordering changes that would otherwise be flagged by the linter in those files? That doesn't sound good to me if i am interpreting that correctly.

I was just mistaken about this. Yes we can just move the C to the top of the files as @monstermunchkin suggests.

Thanks @monstermunchkin @markylaing that sounds good.

[tomponline]

Thanks!