-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suffix custom ISO volumes with ".iso" #12005
Merged
tomponline
merged 10 commits into
canonical:main
from
monstermunchkin:issues/11996-recover-iso-volumes
Jul 14, 2023
Merged
Suffix custom ISO volumes with ".iso" #12005
tomponline
merged 10 commits into
canonical:main
from
monstermunchkin:issues/11996-recover-iso-volumes
Jul 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monstermunchkin
force-pushed
the
issues/11996-recover-iso-volumes
branch
4 times, most recently
from
July 13, 2023 13:27
b53898f
to
4f75979
Compare
monstermunchkin
force-pushed
the
issues/11996-recover-iso-volumes
branch
2 times, most recently
from
July 13, 2023 14:34
3d5f0e8
to
ed9bdbe
Compare
monstermunchkin
force-pushed
the
issues/11996-recover-iso-volumes
branch
from
July 13, 2023 15:40
ed9bdbe
to
7e5730e
Compare
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
This suffixes existing custom ISO volumes with ".iso" in order to distinguish them from regular custom block volumes. Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
This adds tests for deleting custom ISO volumes and re-importing them. Signed-off-by: Thomas Hipp <[email protected]>
Signed-off-by: Thomas Hipp <[email protected]>
monstermunchkin
force-pushed
the
issues/11996-recover-iso-volumes
branch
from
July 14, 2023 08:58
7e5730e
to
fa6e26c
Compare
tomponline
approved these changes
Jul 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @monstermunchkin LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11996