Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suffix custom ISO volumes with ".iso" #12005

Merged

Conversation

monstermunchkin
Copy link
Contributor

@monstermunchkin monstermunchkin commented Jul 12, 2023

Fixes #11996

@monstermunchkin monstermunchkin force-pushed the issues/11996-recover-iso-volumes branch 4 times, most recently from b53898f to 4f75979 Compare July 13, 2023 13:27
@monstermunchkin monstermunchkin marked this pull request as ready for review July 13, 2023 13:28
@monstermunchkin monstermunchkin marked this pull request as draft July 13, 2023 13:32
@monstermunchkin monstermunchkin force-pushed the issues/11996-recover-iso-volumes branch 2 times, most recently from 3d5f0e8 to ed9bdbe Compare July 13, 2023 14:34
@monstermunchkin monstermunchkin marked this pull request as ready for review July 13, 2023 14:58
@monstermunchkin monstermunchkin force-pushed the issues/11996-recover-iso-volumes branch from ed9bdbe to 7e5730e Compare July 13, 2023 15:40
This suffixes existing custom ISO volumes with ".iso" in order to
distinguish them from regular custom block volumes.

Signed-off-by: Thomas Hipp <[email protected]>
This adds tests for deleting custom ISO volumes and re-importing them.

Signed-off-by: Thomas Hipp <[email protected]>
@monstermunchkin monstermunchkin force-pushed the issues/11996-recover-iso-volumes branch from 7e5730e to fa6e26c Compare July 14, 2023 08:58
Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @monstermunchkin LGTM!

@tomponline tomponline merged commit 4a82706 into canonical:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lxd recover: Unable to recover custom ISO volumes
2 participants