Instance: Prevent MAC/address conflict for imported instances #11988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roosterfish
force-pushed
the
fix_import_duplicates
branch
2 times, most recently
from
6a74118 to
435b69b
Compare
tomponline
reviewed
Jul 11, 2023
tomponline
reviewed
Jul 11, 2023
tomponline
reviewed
Jul 11, 2023
tomponline
requested changes
Jul 11, 2023
roosterfish
force-pushed
the
fix_import_duplicates
branch
2 times, most recently
from
f9dc36a to
d59c81f
Compare
tomponline
reviewed
Jul 11, 2023
tomponline
reviewed
Jul 11, 2023
roosterfish
force-pushed
the
fix_import_duplicates
branch
from
d59c81f to
002573d
Compare
tomponline
reviewed
Jul 12, 2023
tomponline
reviewed
Jul 12, 2023
Imported instances have the same set of addresses as their parent. Starting those duplicates should produce a warning. Signed-off-by: Julian Pelizäus <[email protected]>
Signed-off-by: Julian Pelizäus <[email protected]>
roosterfish
force-pushed
the
fix_import_duplicates
branch
from
002573d to
3c450d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imported instances have the same set of addresses as their parent.
Starting those duplicates should produce a warning.
Fixes #11907