Fix linkcheck #11940
Fix linkcheck #11940
Conversation
Signed-off-by: Ruth Fuchss <[email protected]>
Sometimes a failing linkcheck can be ignored, but we still want to see that it is failing. It's currently the last check, so all other checks will be run before it fails. If we add checks after this one, they can be added with condition "always()" to run even if the linkcheck fails. Signed-off-by: Ruth Fuchss <[email protected]>
| @@ -296,7 +296,5 @@ jobs: | |||
| woke-args: "*.md **/*.md -c https://github.com/canonical-web-and-design/Inclusive-naming/raw/main/config.yml" | |||
|
|
|||
| - name: Run link checker | |||
| # This can fail intermittently due to external resources being unavailable. | |||
There was a problem hiding this comment.
Please can we keep this in so that if an external web site is down/unreachable it doesnt prevent the rest of the tests from running. I added this because we periodically get this job fail because the web site in question is down/unreachable.
There was a problem hiding this comment.
See the commit message - this is now the last of the test, so all other tests will run. If we add further tests, we can add them with "always()" so they still run.
If we don't fail this test, we will NEVER see if a link breaks, and we can just as well get rid of the test.
There was a problem hiding this comment.
Does not show it as red/failed in the test results then?
There was a problem hiding this comment.
Yes, the linkcheck will show as red - but that shouldn't prevent from merging?
There was a problem hiding this comment.
OK will merge this now and if we see it causing issues again in the future we can review then.
No description provided.