Added headings in the client/lxd_instances.go file that were missing #11924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ibilalkayy I wonder is it possible for you to submit multiple commits for these changes inside a single PR rather than opening lots of PR. This way we can review and test the changes in one shot. Thanks |
|
@tomponline Alright. I will send one PR. Thank you, for letting me know! |
tomponline
reviewed
Jul 4, 2023
tomponline
requested changes
Jul 4, 2023
|
In lxd_instances.go file, I added 4 headings above the 4 functions. Should I split these comments into 4 commits? |
…ce() function Signed-off-by: Bilal Khan <[email protected]>
…tance() function Signed-off-by: Bilal Khan <[email protected]>
…ance() function Signed-off-by: Bilal Khan <[email protected]>
…tance() function Signed-off-by: Bilal Khan <[email protected]>
|
I now splitted 4 comments into 4 commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I just added headings in the client/lxd_instances.go file that were missing. With these headings, it will be easy to understand what these functions do.
Thank you!