Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lxc-to-lxd #11918

Merged
merged 15 commits into from
Jul 12, 2023
Merged

Fix lxc-to-lxd #11918

merged 15 commits into from
Jul 12, 2023

Conversation

tomponline
Copy link
Member

@tomponline tomponline commented Jul 3, 2023

Fix hang in lxc-to-lxd and re-enable the tests.

This currently doesn't support the storage pool having rsync compression disabled, which is why the tests were passing when run individually but failed if run after the migration test.

To solve this issue I've ensure the migration tests return the rsync compression state to default (enabled) so that the lxc_to_lxd tests pass. I will also look into whether we can support rsync compression disabled in lxc-to-lxd.

Related to #11910

@tomponline tomponline self-assigned this Jul 3, 2023
@tomponline tomponline force-pushed the tp-lxc-to-lxd branch 4 times, most recently from dac7474 to 5f6d1d5 Compare July 4, 2023 08:24
@tomponline tomponline changed the title Fix lxc-to-lxd and lxd-migrate Fix lxc-to-lxd Jul 11, 2023
@tomponline tomponline marked this pull request as ready for review July 11, 2023 15:51
@MusicDin
Copy link
Member

MusicDin commented Jul 12, 2023

Why are the tests failing? I had the similar issues yesterday, is there anything we can do to fix these issues (as they seem random - maybe multiple retries or something like that)?

@tomponline
Copy link
Member Author

Why are the tests failing? I had the similar issues yesterday, is there anything we can do to fix these issues (as they seem random - maybe multiple retries or something like that)?

Those are temporarily issues. One being the ppa webserver being flaky.

@tomponline tomponline closed this Jul 12, 2023
@tomponline tomponline reopened this Jul 12, 2023
@tomponline
Copy link
Member Author

That ceph error looks genuine though

Copy link
Contributor

@roosterfish roosterfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! There is just one typo in the commit message test: Enable lxd-to-lxd test. Think should be lxc-to-lxd.

@tomponline
Copy link
Member Author

I've reproduced the ceph error locally thanks to microceph :)

@tomponline
Copy link
Member Author

Fixed the ceph issue

@tomponline tomponline merged commit 7b272b0 into canonical:main Jul 12, 2023
@tomponline tomponline deleted the tp-lxc-to-lxd branch July 12, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants