-
Notifications
You must be signed in to change notification settings - Fork 933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lxc-to-lxd #11918
Fix lxc-to-lxd #11918
Conversation
dac7474
to
5f6d1d5
Compare
5f6d1d5
to
b1057ba
Compare
b1057ba
to
2f5def0
Compare
Why are the tests failing? I had the similar issues yesterday, is there anything we can do to fix these issues (as they seem random - maybe multiple retries or something like that)? |
Those are temporarily issues. One being the ppa webserver being flaky. |
That ceph error looks genuine though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! There is just one typo in the commit message test: Enable lxd-to-lxd test
. Think should be lxc-to-lxd.
I've reproduced the ceph error locally thanks to microceph :) |
…d MirrorWrite in Mirror function Signed-off-by: Thomas Parrott <[email protected]>
… connection finishes in ConsoleInstanceDynamic Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
…on to rsync Fixes hang. Signed-off-by: Thomas Parrott <[email protected]>
Signed-off-by: Thomas Parrott <[email protected]>
…match Signed-off-by: Thomas Parrott <[email protected]>
…olumeFromMigration Signed-off-by: Thomas Parrott <[email protected]>
…nc xattrs Signed-off-by: Thomas Parrott <[email protected]>
2f5def0
to
7223e82
Compare
Fixed the ceph issue |
Fix hang in lxc-to-lxd and re-enable the tests.
This currently doesn't support the storage pool having rsync compression disabled, which is why the tests were passing when run individually but failed if run after the migration test.
To solve this issue I've ensure the migration tests return the rsync compression state to default (enabled) so that the lxc_to_lxd tests pass. I will also look into whether we can support rsync compression disabled in lxc-to-lxd.
Related to #11910