Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: inclusive naming should fail on error #11872

Merged
merged 2 commits into from
Jun 22, 2023
Merged

github: inclusive naming should fail on error #11872

merged 2 commits into from
Jun 22, 2023

Conversation

simondeziel
Copy link
Member

@simondeziel simondeziel commented Jun 21, 2023 •
edited
Loading

@simondeziel simondeziel marked this pull request as ready for review June 22, 2023 00:34
@simondeziel simondeziel requested a review from tomponline June 22, 2023 00:34
@tomponline
Copy link
Member

@simondeziel thanks! Its odd that this check requires an explicit setting to fail on error, whereas all the other steps default to it.

@tomponline tomponline merged commit c6eab2e into canonical:master Jun 22, 2023
@simondeziel simondeziel deleted the woke-fail-on-error branch June 22, 2023 12:08
@simondeziel
Copy link
Member Author

Indeed, that's an odd default choice. This reminds me that I should have linked to the project's doc: https://github.com/get-woke/woke-action#inputs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomponline tomponline Awaiting requested review from tomponline

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simondeziel @tomponline