Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security.devlxd.images is not live-updatable for VMs #14206

Closed
simondeziel opened this issue Oct 4, 2024 · 0 comments · Fixed by #14445
Closed

security.devlxd.images is not live-updatable for VMs #14206

simondeziel opened this issue Oct 4, 2024 · 0 comments · Fixed by #14445
Assignees
@markylaing
Labels
Improvement Improve to current situation

Comments

@simondeziel
Copy link
Member

security.devlxd.images is live-updatable for containers but not for VMs:

$ lxc launch ubuntu-minimal-daily:24.04 c1
$ lxc config set c1 security.devlxd.images true

$ lxc launch ubuntu-minimal-daily:24.04 v1 --vm
$ lxc config set v1 security.devlxd.images true
Error: Key "security.devlxd.images" cannot be updated when VM is running

I haven't look at the implementation but I suspect this config key doesn't change anything on the guest side as the permission to access the needed API endpoint is evaluated at on the LXD host side.
@simondeziel simondeziel added the Improvement Improve to current situation label Oct 4, 2024
@markylaing markylaing mentioned this issue Nov 11, 2024
Merged
tomponline added a commit that referenced this issue Nov 11, 2024
@tomponline
Make security.devlxd.images live-updatable for VMs (#14445)
817f559 
#13878 Added `security.devlxd.images` for virtual machines but this key
was not live-updatable. There was no particular reason for this. The
endpoint is always available in the LXD agent and access is restricted
by the host daemon.

This PR allows the config key to be set while the instance is running.

Closes #14206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markylaing markylaing

Labels
Improvement Improve to current situation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make security.devlxd.images live-updatable for VMs markylaing/lxd
2 participants
@simondeziel @markylaing